Rails 6: Add/remove foreign keys when truncating during tests #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed namespacing Fixed calls to coerce tests Fix tests
aidanharan
force-pushed
the
fix-truncation-tests
branch
from
68d08d1 to
ebfd121
Compare
wpolicarpo
reviewed
Apr 3, 2020
aidanharan
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSSQL does not allow tables to be truncated if they have foreign key constraints. This is the cause of the
ActiveRecord::StatementInvalid: TinyTds::Error: Cannot truncate table 'author_addresses' because it is being referenced by a FOREIGN KEY constraint.errors in the tests.For the tests that involve truncating just one table I have removed the foreign key, performed the test and then restored the foreign key at the end.
I have coerced the test that truncates all tables as I would need to remove all foreign keys in all tables and then later restore them and I don't know an easy way of doing that.
References:
Before
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/669760945?utm_medium=notification&utm_source=github_status
After
https://travis-ci.org/github/rails-sqlserver/activerecord-sqlserver-adapter/jobs/670157194?utm_medium=notification&utm_source=github_status